Advanced

Broadcom Driver Dispute Uglier Than Necessary

Posted by dcparris on · 29 comments
LXer - Linux News; By D.C. Parris (Charlotte, USA)
Mail this story
Print this story

LXer Feature: 07-Apr-2007

It all started with a message describing copied code and offering a solution.

Duly Notified

Michael Buesch posted a message addressed to Marcus Glocker on a few wireless and Linux kernel development lists, as well as CC'ing several members of the Broadcom reverse-engineering team to the effect that GPL'ed code had been copied verbatim and committed to the bcw team's CVS repository. He posted late on April 4th. Theo De Raadt responded roughly an hour and a half later, focusing almost solely on the manner in which the notice was given. Were it not for the restraint of the majority of developers reading the lists, the issue would have quickly turned rather ugly.

The Flame War

Reading Theo's response, one would think that Buesch had posted a vulgar message. However, on reading the actual thread, I read no real malice in Buesch's message. It appears to be a straightforward request to communicate about potential license violations. Buesch starts off suggesting a potential problem and then outlines the problems he sees initially. He expresses an interest in cooperating - if the BSD developers show cooperation by seeking permission.



Marcus Glocker's response came the following morning, and acknowledged that there were issues with the code:

Quoting:I am aware that right now a lot of lines in bcw are written in a way with a too close eye to your code. That's out of question, and I have already informed Theo about that fact before you got in touch with us.



What strikes me as odd is de Raadt's heated response, given he (allegedly) knew there were problems. And why would he refer to Glocker's mistake as an "accidental commit"? [quote]He should contact you, when he does not known that he's been found to have made mistakes?[quote]

and... [quote] As I understand it, Marcus' process involved borrowing a few pieces of the GPL codebase during his development process, so that he could write further stubs in other parts. Then his process was supposed to involve him commiting the pieces he had written himself, but not the momentarily written GPL parts. And that is where a mistake happened; as I understand it. I don't think he intentionally did it.[quote]


Less than twelve hours later, Glocker drops the driver altogether in what appears to be an overreaction to the Linux developers' request. Based on the messages, it appears he dropped it because he felt he had been attacked. Whether he was influenced by de Raadt, as suggested by at least one post, is unclear. What is clear is that he, nor de Raadt, ever attempted, beyond his initial response, to resolve the dispute at all in a way that would allow him to keep the code he was using.



Simply put, Glocker could have had the code - much of it anyway - re-licensed exactly as it was. If he needed to remove the offending code, it would only have been temporary, until he got the issue resolved. He could then have picked up where he left off. Instead, he chose to drop the whole driver.



de Raadt Steals the Show

What I found interesting about the whole affair was not that there was a violation, but the reaction when it was brought to the OpenBSD developers' attention. By all appearances - and I have little else to go on, Glocker did make a mistake. I believe his mistake was not 'accidentally' committing the code to the public CVS repository, but in how he attempted to work with the code. Although I am not a programmer, it seems prudent to me to keep the GPL'ed code separate until I've re-written the sections I needed to re-write. Instead, Glocker committed GPL'ed code, apparently several times. Even if he is telling the truth, multiple commits does not look at all like an accidental commit. No, his mistake lies in assuming he could commit the GPL'ed code, and then re-writing it, on the fly, so to speak.



There was, in fact a mistake - something that GLocker and de Raadt both acknowledge. They each make conflicting statements about the nature of the mistake. But worse, de Raadt chose to make a big deal out of the manner in which the notice was made. To keep things in perspective, this was not a BSA-styled swat raid on the OpenBSD headquarters, a al Ernie Ball. This was an announcement to the developer community involved in the development of kernel and wireless drivers. de Raadt never took the Linux developers' complaint seriously at all - a poor way to handle such a complaint. In fact, de Raadt resorted to name calling throughout much of the exchange.



de Raadt accused the Linux developers of "ganging up" on one guy, when, in fact, one developer, representing a team, issued a notice to other developers. de Raadt acts as if he is defending his troops against a rival military commander, trying to muscle in on his command. It's taboo in the military. The rest of the exchange, however, occurs between him and several other developers, most of whom appear to be from the Linux community. de Raadt's posts definitely misrepresent the views expressed by some of the Linux developers, and he actually went so far as to suggest the Linux developers had accused Glocker of "theft". That was not the word the Linux developers used, although they definitely expressed complete puzzlement as to how a developer working on BSD drivers could somehow "accidentally" copy and paste GPL'ed code, or to think doing so was somehow o.k. They believed the actions were intentional.



Although good leaders defend their troops, that generally applies when the troops are being wrongly accused. In this case, despite Glocker's apparent concession, de Raadt spent much of the time blustering about the nature of the notice. The better way to have handled the charge would have been to take it seriously - after all, is not our community supposed to be quick to resolve issues? By all appearances, Glocker did have an interest in seeking resolution, even if it wasn't the concession the Linux developers requested. Yet, de Raadt stole the show, quarreling at every chance with the Linux developers. In other words, de Raadt might have done both communities a favor by staying out of it. The issue might have been quickly and quietly resolved to everyone's satisfaction.



Final Thoughts

For Glocker's part, he only made two posts that I counted - one acknowledging Buesch's point and the other stating he was dropping development of the driver altogether. This was entirely unnecessary, and it is difficult to believe that he wasn't heavily influenced by de Raadt's antics. One doesn't have to be requested or even ordered to respond a certain way. Seeing a leader's reaction can, by itself, influence the way we react. That said, the Linux developer team might have been better served to bite their tongues until they were able to see how Glocker responded, before accusing him of intentional copyright infringement - even if they believed that to be the case. They at least waited until they saw de Raadt's response. They didn't even respond in kind when de Raadt referred to them using crude language.



The lesson is simple. Communicate and observe the licenses. There is no other way to put it. All of this could easily have been avoided if only Glocker had conferred with the Linux developer team. At the very least, de Raadt could have worked with Glocker and the Linux developers to remove the code until they resolved the issue. Our community is supposed to be different from the litigious proprietary world. That doesn't mean developers should let others take unfair advantage of them. Nor does it give us the right to stonewall and bluster in order to avoid a problem. It is difficult for us to claim we're different - and we do make that claim frequently - if we act the same as the non-free developers.



References

  • http://thread.gmane.org/gmane.linux.kernel.wireless.general/1558

  Nav
» Read more about: Story Type: Editorial, LXer Features; Groups: Community, GNU, Linux

» Get new stories by e-mail: nightly or as they are published

« Return to the newswire homepage

  Related stories
» More like this

Comments (29)

We need to have Theo de Rant around...

...to remind us of what good de-facto leaders we've got in the GNU and Linux camps.

I read through major chunks of that exchange myself, and came to largely the same conclusions. Theo's fulminations seemed to have an undertone of, "We don't use the GPL; why should you?" as well as a determination to turn the topic towards something other than the "accidentally deliberate borrowing", something where he could presume the moral high ground. I've seen the same tactics used by guilty children and children-inside, often with arguments which amount to "I stole it fair and square!"

This provides a sharp contrast with Richard Stallman, who, in equivalent situations, usually proceeds to calmly belabor and explain his point until he's sure that you either understand his position or are trying hard not to. Not that Richard, or his people skills, are perfect by any means; but, with Theo around for contrast, it's easier to see how Richard's usually calm manner and deeply-reasoned convictions have helped make GNU/FSF an emerging force.
And Richard doesn't call you ugly names. BTW, I nearly inserted a line about how Theo's behavior reminds me of marital counselees I've dealt with. ;-)
Besides his argument that the linux developer should have contacted Marcus directly, not publicly on a mailing list, to spare him the public attention. Well, if he hadn't overreacted so severely, I and many others would never have heard about this story. It could have been resolved calmly and quietly among the involved parties.

Bob T
When Theo yells out as he does (recently its target was Intel and that company which has just joined the LF), it's pretty much justified and it's effective. Michael Larabel is trying similar things with ATI, but he's too polite, IMHO.
Effective? Not. Hysterical hissy fits and insults don't win people over. It drives them away. The real heroes of FOSS are the ones who use patience, persistence, and persuasion to get things done.

@tuxchick: Does that viewpoint apply to Microsoft?

> Does that viewpoint apply to Microsoft?

No heros at Microsoft tuxtom. You should know that by now.
Don't burst my bubble, Jim.

Interestingly, this "controversy" is already referenced on Theo's wikipedia page with a link back to Lxer.
tuxtom, when you're the biggest and richest gorilla, you can get away with an awful lot of poor behavior. :)

Really just a symptom of cultural change

I find this dust-up interesting in how the GNU/Linux Development has become more formalized, more institutional and perhaps more distant from it's own GNU roots. While I expect the OBSD culture would have easily fixed any problem with an informal email between developers, the correct path in the GNU/Linux culture is now a more formal declaration. Culturally, such formality violates the small cadre developer ethos one finds in OBSD. Especially since this highlights that GNU/Linux development no longer shares this model.

Relationships that once could be taken for granted as sharing a cultural model should be reviewed for having lost this innate leverage. Otherwise they will create an ongoing series of avoidable dust-ups and increased ill-will.

Eyes open people - this wasn't personal and should have been expected. Somebody should ask if McKinsey would do some pro-bono work for the FOSS world.

ean
Quoting:While I expect the OBSD culture would have easily fixed any problem with an informal email between developers


I disagree. Theo de Raadt is a very difficult person and spats like this have happened before. I think that if he had stayed out of it, it would have been resolved quite fast.
> Theo de Raadt is a very difficult person

That's certainly the history.
I think this whole thing is an extremely unfortunate example of the all too common miscommunication on the Internet. A friend of mine who has extensive experience with *BSD and GNU/Linux said he thought Buesch was mostly in the wrong. I read the beginning of the thread and I'm not very sure where most of the blame lies. I have very little experience with *BSD and a lot with GNU/Linux, so I can't claim to be unbiased.

It does seem very clear that it was a mistake to commit code from the GPL Linux driver to the OpenBSD public CVS, as this implies that it is under a non-copyleft license and therefore free to be used in non-free code. The Linux developers make it clear this is exactly what they wished to avoid by licensing under the GPL.

On the other hand, as de Raadt says in his initial response, the Linux guys could have communicated privately before making a a public issue of it. de Raadt acts like OpenBSD developers are under attack, which I think is a gross overreaction, but it was insensitive to post so publicly with no warning or private communication. I think both sides have forgotten that they should be on the same side. OpenBSD and OpenSSH are great contributions to Free software and de Raadt is passionate about Free drivers even if he doesn't like the GPL.
@jrogers

Ditto from where I stand.
> On the other hand, as de Raadt says in his initial response, the Linux guys could have communicated privately before making a a public issue of it.

But as has been said before, open source development is not done in private. He was not notified in a press conference on CBS. The relevant groups were sent a message.

And so what if other people did find out about it? Is the problem that people now know the BSD developers are capable of making mistakes? It shouldn't have been a problem even if it had been on the front page of the New York Times. I don't see how it is better to keep others in the dark about improper code in BSD. Would it be better if de Raadt knew about a bug, then six months down the road other developers found out that they had to rewrite from scratch because he didn't tell them?
I don't see where making the initial contact publicly- and come on, the OpenBSD dev list? that's the next best thing to private, and darn near secret- justifies Theo's ensuing hysteria. Nobody would have given it a second thought if Theo hadn't escalated it to The End of the Universe and Life as We Know It.
> I think this whole thing is an extremely unfortunate example of the all too common miscommunication on the Internet.

Well, yes. But miscommunications are made much worse when one of the people involved is a jerk.

And I agree with TC that the OpenBSD developers list was a perfectly appropriate forum for the discussion.
>And I agree with TC that the OpenBSD developers list was a perfectly appropriate forum for the discussion.

Which was one of the points I attempted to make in my article, where i compared Buesch's posting to the SBA's tactics.
Actually I think contacting the dev in question (Marcus) privately first would have been a more diplomatic approach. But at some point it was going to end up on a public list anyway, because it involves a number of developers, and it seems clear that some basic OpenBSD procedures regarding commits and checkins were flawed. I did read the whole thread (pass the Valium please, my ears are still ringing), and Theo knew Marcus was studying and modifying some GPL Broadcom driver code, and mingling it where it should not have been mingled. The way the code was being handled was asking for trouble. Especially in a project like OpenBSD which makes frequent and loud pronouncements about how clean their codebase is, and how it's cleaner than anyone else's, and Linux is all polluted, and everyone else is impure, etc.

Martin Buesch did not make legal threats or try to take his code away: "We would not be opposed to relicensing parts of our code under the BSD license on an explicit case-by-case base."

Somewhere later in the thread Theo, after Marcus deleted all of his work from CVS and quit, ranted about "800 hours of hobby work wasted." That rests squarely on Theo's mis-handling of the whole deal. Honest to gosh, how can anyone read the stuff he posts and not go "eee he is the crazy one"?

It starts here: http://thread.gmane.org/gmane.linux.kernel.wireless.general/...
I don't think CCing to *any* list is appropriate *until* after private communications break down - but then again, I don't believe we should resort to using the pillory or scarlet letters.

I can't really see *any* purpose to including the people that Buesch did except for public humiliation.
I think this whole big fuss is about pride and reputation. What is it that they are concerned about when the whole idea of FOSS is to study, learn and build on the work of predecessors?

humbleness is a vitue
Quoting:I can't really see *any* purpose to including the people that Buesch did except for public humiliation.


Unfortunately, I think "AHA! I CAUGHT YOU!" has become part of the GPL culture. It's unfortunate, and I can't imagine rms ever wanted that, but there it is. Play fair and square or I blast you, and hopefully get on slashdot. It stinks.

As for Theo's behavior... he was abrasive, name calling, and nasty. Theo ALWAYS gets that way when people try to appear to be one thing but are actually something else. When corporations say they're open source friendly and they don't actually open up he calls them LIARS in all caps. When people say they're looking for reconciliation, but lay out a laundry list of grievances and CC news sources, he also uses LIAR and other words. It's ugly, it's undiplomatic, but it's also true. Since he doesn't mince words, that makes him a jerk in many peoples' book. But at least he calls them like he sees them, and he's pretty much always right.
> Theo ALWAYS gets that way when people try to appear to be one thing but are actually something else.

Actually, as far as I've been able to tell over the years, Theo always gets that way, period.
Well now, if Theo is so smart and so right, then there should be a good, positive outcome from this dustup, correct? OK, the tally so far:

-Marcus Glocker deleted his code from CVS and quit -Michael Buesch and the other Broadcom driver developers, who invest considerable resources into reverse-engineering because Broadcom is a butthead, withdrew their offer of cooperation, which included re-licensing their code to make it BSD-friendly -The appearance that it is policy for OpenBSD devs to disrespect software licenses -Theo's fans don't seem to respect software licenses either -More people than ever know that Theo would rather throw a tantrum than try to work things out like an adult

Yep, that's some sterling leadership there.
> Play fair and square or I blast you, and hopefully get on slashdot. It stinks.

Enforcing license restrictions is actually a common practice in the computing industry. You might want to check out the internet. It's got stories about proprietary companies preventing others from copying their software.

How is it "blasting" someone to point out that GPL code is not being used properly? And what's the secret? Who cares if every household in the US was CC'd?
> Play fair and square or I blast you, and hopefully get on slashdot. It stinks.

It might not have even made Slashdot had it not been for Theo's overreaction. A much more diplomatic approach would have been:

Glocker responds as he did, Buesch has opportunity to go from there. Theo acknowledges Glocker's error and politely reminds Buesch a private e-mail would have sufficed. Buesch would have had opportunity to explain he would have used private e-mail if not for such a flagrant violation (removing attribution, for example) Theo (who didn't deny knowing about the code use) promises to improve the OpenBSD development process Glocker and Buesch work things out and Glocker maybe needs to re-write a few things instead of everything. Everyone wins.

Frankly, calling Buesch "inhuman" in light of the fact that he did not resort to BSA tactics is going way overboard, don't you think? Inhuman? Come on! Go ask Ernie Ball about "inhuman". How about a swat-styled raid with the 6:00 news there to watch? How about not even the remotest notice that anything is wrong?

And where did Theo get off on this one?
Quoting: > He should start to contact us to get relicensing permission from > us to speed up bcw development and stay legal.

What bullshit. He should contact you, when he does not known that he's been found to have made mistakes?


Glocker had just been put on notice that he had made a mistake. The Linux developers wanted him to respond, to contact them to resolve it. Theo attempts to make it seem like Glocker is supposed to be a mind reader, as if the Linux developers are so mean, they want him to just up and contact them without notice (despite having served notice).

Now that's a bunch of bull.
Oh I can sure appreciate and understand why Theo reacted the way he did. Not agree mind, but understand.

Why?

OpenBSD has as it's biggest, indeed only, selling point is it is Secure. Secure by default. X exploits in the default install in Y decades and so on.

Which all boils down to one word, and one word only.

TRUST

Is the emperor wearing clothes? Or are his feet made of glass? How many metaphors can dance on the head of pin?

This one *terrible* mistake has dealt a huge blow to the years of value that has been given to that trust. I could see this as being the mortal blow to that entire project which IMHO would be an appalling tragedy.
I think it's very telling that Mr. Buesch CC'ed the "GPL violations" ( license-violation@gpl-violations.org ) email address at the FSF right in the first email.

What do the legal people who respond to violations have to do with a sincere fact finding effort that's not "out for blood"? Why include them before you have any kind of feedback from the suspect violator?

I find Mr. Buesch's inclusion of several of the addressees very disingenuous to his stated purpose of the email.
I agree that Buesch could have been more diplomatic. I would have started with a narrower list myself, not to mention omitting the whole "out for blood" comment. That said, Theo's declaration that Buesch is "inhuman" is rather melodramatic.

What really bothers me is Glocker's suggestion that Theo knew in advance what he was doing, and Theo didn't deny that - not that I saw, anyway. What is a project leader doing allowing code to be misused like that? Either he didn't know the details, or he knew the details and allowed it anyway. In the latter case, I think Buesch's CC list might actually be sensible.

Post a comment

A free account is needed to post. Write your comment here first: your text is kept in this browser while you sign up or log in, and is waiting for you when you come back.

Your message:
|||||
10
Markdown: **bold**, *italic*, [text](https://link), - lists, > quotes, $x^2$ for math. Formatting help

Sign up and post (it is free)  or  Log in and post